pxa27x and pinctrl-single

[Haojian Zhuang]

On 7 June 2013 22:50, Mike Dunn <mikedunn at newsguy.com> wrote:
> On 06/06/2013 06:21 PM, Haojian Zhuang wrote:
>> On Fri, Jun 7, 2013 at 8:48 AM, Mike Dunn <mikedunn at newsguy.com> wrote:
>>> On 06/06/2013 04:58 PM, Haojian Zhuang wrote:
>>>> On 7 June 2013 01:33, Mike Dunn <mikedunn at newsguy.com> wrote:
>>>>>
>>>
>>>
>>> [...]
>>>
>>>
>>>>>
>>>>> Yes, but currently pinctrl-single only supports writing one register for a given
>>>>> pin (with multiple pins sharing a register if bit-per-mux==true).  On pxa27x, a
>>>>> pin's alt function is determined by the values written to both the GAFRx and the
>>>>> GPDRx registers, so I think that pinctrl-single may need to allow a device tree
>>>>> to specify multiple reg/value/mask sets for any one pin.  I don't have a
>>>>> pxa3xx/mmp developer's manual handy, but from the code it appears that on these
>>>>> arches the direction register is irrelevant to the mux setting.
>>>>>
>>>>
>>>> No, it's not need to access both GAFRx & GPDRx. Let's focus on PXA27x first.
>>>>
>>>> GPIO ‘x’ Alternate Function Select Bits (where x = 112 through 120)
>>>> A bit-pair in this register determines the corresponding GPIO pin’s
>>>> functionality as one of the alternate functions that is mapped to it or as a
>>>> generic GPIO pin.
>>>>
>>>> 0b00 = The corresponding GPIO pin (GPIO<x>) is used as a general-
>>>> purpose I/O.
>>>> 0b01 = The corresponding GPIO pin (GPIO<x>) is used for its alternate
>>>> function 1.
>>>> 0b10 = The corresponding GPIO pin (GPIO<x>) is used for its alternate
>>>> function 2.
>>>> 0b11 = The corresponding GPIO pin (GPIO<x>) is used for its alternate
>>>> function 3.
>>>>
>>>> We can see that GAFRx configures the pinmux. That's all. We can use
>>>> pinctrl-single
>>>> driver to cover this.
>>>
>>>
>>> But on the pxa27x there are usually *two* meanings for any one of the 3 alt
>>> functions, depending on the direction.  As a random example... gpio28 alt fn
>>> 0b01 is AC97_BITCLK if the direction is input, but is I2S_BITCLK if the
>>> direction is output (from PXA27x Developer's Manual, Table 24-2).
>>>
>>
>> You didn't understand the alternate function. GPIO mode is only one mode
>> of alternate functions. Because GPIO means that user can program the
>> pin, you also need to configure the direction for GPIO usage.
>>
>> Most of pins are either input or output. If the alternate function is
>> AC97_BITCLK,
>> input mode is configured by hardware automatically. You shouldn't configure
>> it in GPDR register. Since it's working in AC97 mode, not GPIO mode. Configuring
>> in GPDR register can't work.
>
>
> This is where you are wrong Haojian.  Now I am sure that this peculiarity is
> unique to pxa2xx.  From pxa27x developer's manual (section 24.4.2)...
>
> GPIO pins can have as many as three alternate input and three alternate output
> functions.
>
> And in the comments above the __gpio_is_occupied() function in gpio-pxa.c you
> mentioned earlier...
>
> /*
>  * On PXA25x and PXA27x, GAFRx and GPDRx together decide the alternate
>  * function of a GPIO, and GPDRx cannot be altered once configured. It
>
>
> I'll try to state it another way... on the old Intel pxa arches, the direction
> bit is effectively a third alt function bit, as "alt function" is defined by the
> newer Marvell processors.
>
> I'll be happy to send you the pxa27x developer's manual if you still have
> doubts.  In the gpio chapter you will see a table with a row for each gpio pin,
> each row containing 6 columns labeled
>
> alt fn 1 (in)
> alt fn 2 (in)
> alt fn 3 (in)
> alt fn 1 (out)
> alt fn 2 (out)
> alt fn 3 (out)
>
> I hope that makes sense now.
>
> Thanks again,
> Mike

Thank you for pointing this to me. I didn't realize the GPDR needs to
be configured
in PXA2xx. It's totally different from PXA3xx.

Since you need to configure both GPDRx and GAFRx. If we are talking
pinctrl-single
as reference, we can make it work by this way.

We need to define two pinmux controllers. One is for GPDRx, and the
other is for GAFRx.
Both of them need to support pinctrl-single,bits property. For any
alternate pins in DTS,
we could include these two pins from two pinmux controllers. What's
your opinion?

Regards
Haojian