[RFC] [PATCH 3/3] IRQ: irq domain: defer of irq ressoure resolve at platform_drv_probe
Alexander Sverdlin
alexander.sverdlin at nsn.com
Fri Jun 7 23:41:15 EST 2013
Hi!
On 05/28/2013 05:08 PM, ext Jean-Christophe PLAGNIOL-VILLARD wrote:
> --- a/drivers/of/platform.c
> +++ b/drivers/of/platform.c
> @@ -131,6 +131,32 @@ void of_device_make_bus_id(struct device *dev)
> }
>
> /**
> + * of_device_alloc_irq - initialize irq of an platfrom_device
^^^^^^^^^^^^^^^^^^^
> + * @dev: plaform_device to work on
> + */
> +int of_device_init_irq(struct platform_device *dev)
^^^^^^^^^^^^^^^^^^
I think, mismatch in function names in the comment and function itself wasn't yet reported...
> +{
> + struct device_node *np = dev->dev.of_node;
> + int num_irq;
> + int ret;
> + struct resource *res = dev->resource;
> +
> + if (!np)
> + return 0;
> +
> + num_irq = of_irq_count(np);
> + if (!num_irq)
> + return 0;
> +
> + res += dev->num_resources - num_irq;
> + ret = of_irq_to_resource_table(np, res, num_irq);
> + if (ret != num_irq)
> + return -EPROBE_DEFER;
> +
> + return 0;
> +}
> +
> +/**
> * of_device_alloc - Allocate and initialize an of_device
> * @np: device node to assign to device
> * @bus_id: Name to assign to the device. May be null to use default name.
I was trying to get attention to this problem already on the list in January-February time frame, but
without success... I will give your code a try... We have exactly these chained interrupt controllers dependencies
and irq_create_of_mapping() was failing... I'll inform you on the test results...
--
Best regards,
Alexander Sverdlin.
More information about the devicetree-discuss
mailing list