[PATCH V5 4/5] ARM: dts: add clock provider information for i2s controllers in Exynos5250

Padma Venkat padma.kvr at gmail.com
Thu Jun 6 13:54:30 EST 2013


Hi Doug,

On Tue, Jun 4, 2013 at 10:49 PM, Doug Anderson <dianders at chromium.org> wrote:
> Padmavathi,
>
> On Tue, Jun 4, 2013 at 5:28 AM, Padmavathi Venna <padma.v at samsung.com> wrote:
>> @@ -471,6 +477,8 @@
>>                 dmas = <&pdma1 12
>>                         &pdma1 11>;
>>                 dma-names = "tx", "rx";
>> +               clocks = <&clock 307>;
>> +               clock-names = "iis";
>
> ...actually, glancing at the driver I'm a little surprised that you
> don't need to list "i2s_opclk0".  Did you test i2s1?

I didn't test i2s1 but i2s_opclk0 is also required. I will resubmit the patch.

>
>>                 pinctrl-names = "default";
>>                 pinctrl-0 = <&i2s1_bus>;
>>         };
>> @@ -481,6 +489,8 @@
>>                 dmas = <&pdma0 12
>>                         &pdma0 11>;
>>                 dma-names = "tx", "rx";
>> +               clocks = <&clock 308>;
>> +               clock-names = "iis";
>
> ...and here.
>
>
> -Doug

Thanks
Padma


More information about the devicetree-discuss mailing list