[PATCH v2 5/5] ARM: davinci: serial: platform code cleanup

Sekhar Nori nsekhar at ti.com
Wed Jun 5 21:41:52 EST 2013


On 5/28/2013 1:58 PM, Manjunathappa, Prakash wrote:
> 1) "struct davinci_uart_config" is introduced to specify
>    UART ports brought out or enabled on the board. But
>    none of the boards use them for that purpose, so clean
>    it up.
> 2) Have pointer to platform device as a argument for
>    davinci_serial_init(), no need of serial_dev in
>    struct soc_info now.
> 3) No need of davinci_serial_setup_clk(), not called from
>    multiple places, hence reduce function call overhead.
> 
> Signed-off-by: Manjunathappa, Prakash <prakash.pm at ti.com>
> Suggested-by: Sekhar Nori <nsekhar at ti.com>

We generally clean up code before undertaking modifications. Is there a
reason why this cannot be done first-up?

Thanks,
Sekhar


More information about the devicetree-discuss mailing list