[PATCH 3/7] USB: chipidea: add PTW, PTS and STS handling

[Alexander Shishkin]

Michael Grzeschik <mgr at pengutronix.de> writes:

> Hey Alex,
>
> On Mon, Jun 03, 2013 at 03:35:37PM +0300, Alexander Shishkin wrote:
>> Michael Grzeschik <mgr at pengutronix.de> writes:
>> 
>> > From: Michael Grzeschik <m.grzeschik at pengutronix.de>
>> >
>> > This patch makes it possible to configure the PTW, PTS and STS bits
>> > inside the portsc register for host and device mode before the driver
>> > starts and the phy can be addressed as hardware implementation is
>> > designed.
>> 
>> The bulk of this patch is good, but the OF part should still go to
>> ci13xxx_imx along with the dt bindings description.
>
> referring to the last discussion [1] about what should be handled
> where, your last statement is pretty confusing. We might say we
> somehow stuck in a loop if i would repost this patch again
> and somebody (probably you :]) is telling me to do the opposite again!

I know it's a difficult topic and I'm sorry for all the confusion. It
was Felipe, he's a big proponent of core drivers fetching everything
related to the core from DT. It's right there in the followups to that
patch.

> If you have a closer look, you can see that we are checking for
> valid pdata:
>
> @@ -408,6 +452,9 @@ static int ci_hdrc_probe(struct platform_device *pdev)
>                 return -ENODEV;
>         }
>
> +       if (!ci->platdata->phy_mode)
> +               ci->platdata->phy_mode = of_usb_get_phy_mode(dev->of_node);
> +
>
> This way we can ensure that platforms without OF still
> can use the pdata. _But_ we always fall back to OF in the
> core _if_ nobody cared. This should be done with all properties
> that are not SoC, but _common_ device specific settings.

Ok, let's leave it like this.

Regards,
--
Alex