[PATCH] arm: dts: omap4-sdp: Add I2c pinctrl data

Santosh Shilimkar santosh.shilimkar at ti.com
Wed Jan 30 19:48:31 EST 2013


On Wednesday 30 January 2013 02:13 PM, Kumar, Anil wrote:
> Hi Sourav,
>
> On Wed, Jan 30, 2013 at 12:10:18, Poddar, Sourav wrote:
>> Hi Luciano,
>> On Wednesday 30 January 2013 11:55 AM, Luciano Coelho wrote:
>>> Hi Sourav,
>>>
>>> On Mon, 2013-01-28 at 16:47 +0530, Sourav Poddar wrote:
>>>> Booting 3.8-rc4 om omap 4430sdp results in the following error
>>>>
>>>> omap_i2c 48070000.i2c: did not get pins for i2c error: -19
>>>> [    1.024261] omap_i2c 48070000.i2c: bus 0 rev0.12 at 100 kHz
>>>> [    1.030181] omap_i2c 48072000.i2c: did not get pins for i2c error: -19
>>>> [    1.037384] omap_i2c 48072000.i2c: bus 1 rev0.12 at 400 kHz
>>>> [    1.043762] omap_i2c 48060000.i2c: did not get pins for i2c error: -19
>>>> [    1.050964] omap_i2c 48060000.i2c: bus 2 rev0.12 at 100 kHz
>>>> [    1.056823] omap_i2c 4807a000.i2c: did not get pins for i2c error: -19
>>>> [    1.064025] omap_i2c 4807a000.i2c: bus 3 rev0.12 at 400 kHz
>>>>
>>>> This happens because omap4 dts file is not adapted to use i2c through pinctrl
>>>> framework. Populating i2c pinctrl data to get rid of the error.
>>>>
>>>> Tested on omap4430 sdp with 3.8-rc4 kernel.
>>>>
>>>> Signed-off-by: Sourav Poddar <sourav.poddar at ti.com>
>>>> Reported-by: Santosh Shilimkar <santosh.shilimkar at ti.com>
>>>> ---
>>> Could you do the same thing for panda? I'm getting the same kind of
>>> errors with it:
>
> omap4 uses pinctrl-single driver for pinmux with DT. Currently
> pinctrl-single driver is getting up after I2C driver. So I2c cannot
> use pinctrl. The below patch solve this issue
>
> http://www.gossamer-threads.com/lists/linux/kernel/1669067
>
> Can you try with this ? it may solve it.
>
OMAP i2c driver already takes care of -EPROBE_DEFER. The issue
as you see from the log is not probe failure but missing the
pin information in DT blob. And thats what patch does.

Regards
santosh



More information about the devicetree-discuss mailing list