[PATCH 2/6] ARM: dts: Add MFC codec support for Exynos4 DT machines

[Sachin Kamat]

Hi Sylwester,


>> +     mfc: codec at 13400000 {
>> +             compatible = "samsung,mfc-v5";
>> +             reg = <0x13400000 0x10000>;
>> +             interrupts = <0 94 0>;
>> +             samsung,power-domain = <&pd_mfc>;
>
> Please add:
>                 status = "disabled";

OK

>
>> +     };
>>  };
>> +static void __init exynos4_reserve(void)
>> +{
>> +#ifdef CONFIG_S5P_DEV_MFC
>
> Where is this symbol supposed to be enabled ?
>
> Don't you need a change like this as a part of this patch ?

Yes. Good catch. Since this symbol was defined under other machines
which were getting enabled, I did not notice this.

>

-- 
With warm regards,
Sachin