[PATCH] Move the fdt*_t type definitions to fdt.h

Jerry Van Baren vanbaren at cideas.com
Tue Jan 29 00:29:03 EST 2013


On 01/27/2013 11:52 PM, David Gibson wrote:
> On Sun, Jan 27, 2013 at 09:44:37PM -0500, Gerald Van Baren wrote:
>> Arguably they belong there since they are fundamental to the fdt.
>> As a side effect, I had to flip the order of #includes of fdt.h and
>> libfdt_env.h in libfdt.h since libfdt_env.h needs the fdt*_t definitions.
>>
>> Signed-off-by: Gerald Van Baren <gvb at unssw.com>
>> ---
>>
>> I'm not sure I like this, but submit it for your consideration.  If, for
>> some reason, libfdt_env.h needed to (re)define something in fdt.h, it
>> would be unable to do so. :-/
>
> Sorry, nack on this one.  fdt.h is supposed to be as independent as we
> can make it from the environment in which its being compiled.  That
> means I don't want it to include *any* system headers, even stdint.h.

No problem, it didn't feel right to me either.  Thank you for your 
consideration. :-)

Best regards,
gvb



More information about the devicetree-discuss mailing list