[PATCH 1/8] Adjust util_is_printable_string() comment and fix test

[Simon Glass]

Hi David,

On Tue, Jan 22, 2013 at 6:33 PM, David Gibson
<david at gibson.dropbear.id.au> wrote:
> On Mon, Jan 21, 2013 at 12:59:15PM -0800, Simon Glass wrote:
>> This commit which changed the behaviour of this function broke one
>> of the tests. Also the comment should be updated to reflect its new
>> behaviour.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>
> Acked-by: David Gibson <david at gibson.dropbear.id.au>
>
> Jon, please apply asap, regardless of what we do with the rest of this
> series, since it fixes up the ugly test failure we have right now.
>
>> ---
>>  tests/run_tests.sh |    4 +---
>>  util.h             |    8 +++++---
>>  2 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/tests/run_tests.sh b/tests/run_tests.sh
>> index dd7f217..e04512c 100755
>> --- a/tests/run_tests.sh
>> +++ b/tests/run_tests.sh
>> @@ -498,9 +498,7 @@ fdtget_tests () {
>>
>>      # run_fdtget_test <expected-result> [<flags>] <file> <node> <property>
>>      run_fdtget_test "MyBoardName" $dtb / model
>> -    run_fdtget_test "77 121 66 111 \
>> -97 114 100 78 97 109 101 0 77 121 66 111 97 114 100 70 97 109 105 \
>> -108 121 78 97 109 101 0" $dtb / compatible
>> +    run_fdtget_test "MyBoardName MyBoardFamilyName" $dtb / compatible
>
> I would also like to see a test of the old-style behaviour still
> present, by explicitly enabling it with -t bu.

OK - I have sent a v2 of this patch.

Regards,
Simon

>
> --
> David Gibson                    | I'll have my music baroque, and my code
> david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
>                                 | _way_ _around_!
> http://www.ozlabs.org/~dgibson