[PATCH] drm/i2c: Add driver for PTN3460 LVDS/DP bridge

Daniel Vetter daniel at ffwll.ch
Fri Jan 25 08:22:00 EST 2013


On Thu, Jan 24, 2013 at 7:09 PM, Sean Paul <seanpaul at chromium.org> wrote:
> This patch adds the driver for the PTN3460 LVDS/DP bridge chip.
>
> The driver allows the EDID emulation to be selected from device tree,
> along with specifying the GPIOs driving powerdown and reset pins.
>
> The chip has a bug in it such that when the powerdown and reset pins
> are toggled, the hotplug line blips before the bridge is completely
> ready. This forces us to wait for the maximum specified setup time
> (90ms) before interacting with the chip via i2c or doing DP training, as
> opposed to watching the hotplug line. This limitation means that we need
> to synchronize the bridge driver with the DP driver via the
> ptn3460_wait_until_ready function.
>
> Signed-off-by: Sean Paul <seanpaul at chromium.org>
> ---
>  .../devicetree/bindings/drm/i2c/ptn3460.txt        |   27 ++
>  drivers/gpu/drm/Kconfig                            |    2 +
>  drivers/gpu/drm/i2c/Kconfig                        |    6 +
>  drivers/gpu/drm/i2c/Makefile                       |    2 +
>  drivers/gpu/drm/i2c/ptn3460.c                      |  283 ++++++++++++++++++++

Afaict from reading through the code, this is just a bit of
special-purpose i2c code to control some hw. Imo you can just put that
into your driver directory, since currently all the drivers in drm/i2c
are drm_encoder_slaves (potentially shared between drivers), and I
think we should keep it at that.

Of course, if you plane to extend that to such an encoder slave
driver, then we could move it back.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the devicetree-discuss mailing list