[PATCH v2 2/3] arm: mvebu: Enable USB controllers on Armada 370/XP boards

[Ezequiel Garcia]

Hi Nobuhiro,

On Wed, Jan 23, 2013 at 12:26 PM, Ezequiel Garcia
<ezequiel.garcia at free-electrons.com> wrote:
> This patch activates every USB port provided by each SoC.
> Except for Armada XP Openblocks AX3-4 board,
> where we enable only the first two USB ports
> until we have more information on the third one usage.
>
> Cc: Lior Amsalem <alior at marvell.com>
> Cc: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> Cc: Gregory CLEMENT <gregory.clement at free-electrons.com>
> Tested-by: Nobuhiro Iwamatsu <iwamatsu at nigauri.org>
> Tested-by: Florian Fainelli <florian at openwrt.org>
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia at free-electrons.com>
> ---
> Changes from v1:
>  * Squashed separate per-board patches into this one,
>    as suggested by Arnd.
>  * Remove usb at d0052000 activation in OpenBlocks AX3-4
>    until we have more information about it.
>
>  arch/arm/boot/dts/armada-370-db.dts              |    8 ++++++++
>  arch/arm/boot/dts/armada-370-mirabox.dts         |    8 ++++++++
>  arch/arm/boot/dts/armada-xp-db.dts               |   12 ++++++++++++
>  arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts |    6 ++++++
>  4 files changed, 34 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-370-db.dts b/arch/arm/boot/dts/armada-370-db.dts
> index 8e66a7c..3d93902 100644
> --- a/arch/arm/boot/dts/armada-370-db.dts
> +++ b/arch/arm/boot/dts/armada-370-db.dts
> @@ -74,5 +74,13 @@
>                         status = "disabled";
>                         /* No CD or WP GPIOs */
>                 };
> +
> +               usb at d0050000 {
> +                       status = "okay";
> +               };
> +
> +               usb at d0051000 {
> +                       status = "okay";
> +               };
>         };
>  };
> diff --git a/arch/arm/boot/dts/armada-370-mirabox.dts b/arch/arm/boot/dts/armada-370-mirabox.dts
> index 1864820..dd0c57d 100644
> --- a/arch/arm/boot/dts/armada-370-mirabox.dts
> +++ b/arch/arm/boot/dts/armada-370-mirabox.dts
> @@ -62,5 +62,13 @@
>                          * Wifi/Bluetooth chip
>                          */
>                 };
> +
> +               usb at d0050000 {
> +                       status = "okay";
> +               };
> +
> +               usb at d0051000 {
> +                       status = "okay";
> +               };
>         };
>  };
> diff --git a/arch/arm/boot/dts/armada-xp-db.dts b/arch/arm/boot/dts/armada-xp-db.dts
> index c7035c5..c84e1fe 100644
> --- a/arch/arm/boot/dts/armada-xp-db.dts
> +++ b/arch/arm/boot/dts/armada-xp-db.dts
> @@ -97,5 +97,17 @@
>                         status = "okay";
>                         /* No CD or WP GPIOs */
>                 };
> +
> +               usb at d0050000 {
> +                       status = "okay";
> +               };
> +
> +               usb at d0051000 {
> +                       status = "okay";
> +               };
> +
> +               usb at d0052000 {
> +                       status = "okay";
> +               };
>         };
>  };
> diff --git a/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts b/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts
> index ec36864..3818a82 100644
> --- a/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts
> +++ b/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts
> @@ -133,5 +133,11 @@
>                         nr-ports = <2>;
>                         status = "okay";
>                 };
> +               usb at d0050000 {
> +                       status = "okay";
> +               };
> +               usb at d0051000 {
> +                       status = "okay";
> +               };
>         };
>  };
> --
> 1.7.8.6
>

I'd like to bring this patch to your attention.
As you can see, I've removed the

               usb at d0052000 {
                       status = "okay";
               };

from the OpenBlocks AX3-4 board dts file, since you mentioned this
board uses that USB
port for a PCIe connector -- if I understood correctly.

It's interesting to note that Mirabox board doesn't provide direct
access to its USB ports either,
but instead they are used to connect a GL827L MMC card reader.
However, we activate USB ports anyway, since it's needed for that to work fine.

So, IMHO, if OpenBlocks uses third USB port to connect some PCIe controller,
we should activate it in the dts file.

What do you think?

-- 
    Ezequiel