[PATCH 1/2] ARM: dts: Fix compatible value of pinctrl module on EXYNOS5440

Linus Walleij linus.walleij at linaro.org
Thu Jan 17 19:34:53 EST 2013


On Thu, Jan 3, 2013 at 1:20 AM, Kukjin Kim <kgene.kim at samsung.com> wrote:

> From: Thomas Abraham <thomas.ab at samsung.com>
>
> Fix the incorrect compatible property value of pin-controller module
> EXYNOS5440 SoC.
>
(...)
>
>         pinctrl {
> -               compatible = "samsung,pinctrl-exynos5440";
> +               compatible = "samsung,exynos5440-pinctrl";
>                 reg = <0xE0000 0x1000>;
>                 interrupt-controller;
>                 #interrupt-cells = <2>;
> diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
> index 953737d..cac4b45 100644
> --- a/drivers/gpio/gpio-samsung.c
> +++ b/drivers/gpio/gpio-samsung.c
> @@ -3026,7 +3026,7 @@ static __init int samsung_gpiolib_init(void)
>         static const struct of_device_id exynos_pinctrl_ids[] = {
>                 { .compatible = "samsung,pinctrl-exynos4210", },
>                 { .compatible = "samsung,pinctrl-exynos4x12", },
> -               { .compatible = "samsung,pinctrl-exynos5440", },
> +               { .compatible = "samsung,exynos5440-pinctrl", },
>         };
>         for_each_matching_node(pctrl_np, exynos_pinctrl_ids)
>                 if (pctrl_np && of_device_is_available(pctrl_np))

I am tempted to apply this patch just to annoy people with
obsessive-compulsive disorder (but that's a bit mean).
Reference:
http://izismile.com/2011/08/16/obnoxious_ways_to_drive_people_with_ocd_nuts_16_pics.html

But I'd like a word from Rob, Grant or Stephen so I have some
guidance here.

Yours,
Linus Walleij


More information about the devicetree-discuss mailing list