[RFC PATCH 1/5] ARM i.MX6q: Add GPU, VPU, IPU, and OpenVG resets to system reset controller

Philipp Zabel p.zabel at pengutronix.de
Fri Jan 11 00:54:49 EST 2013


Am Donnerstag, den 10.01.2013, 14:56 +0800 schrieb Shawn Guo:
> Hi Philipp,
> 
> On Wed, Jan 09, 2013 at 06:17:15PM +0100, Philipp Zabel wrote:
> > Signed-off-by: Philipp Zabel <p.zabel at pengutronix.de>
> > ---
> >  .../devicetree/bindings/reset/fsl,imx-src.txt      |   45 ++++++++++++++++++++
> >  arch/arm/mach-imx/src.c                            |   41 ++++++++++++++++++
> >  include/linux/imx-src.h                            |    6 +++
> >  3 files changed, 92 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/reset/fsl,imx-src.txt
> >  create mode 100644 include/linux/imx-src.h
> 
> I'm with Stephen that we should try to create a common API for this.
> Instead of ask device drivers to call IMX specific imx_src_reset(),
> we should have them call some type of common API with struct device
> as the argument.

Agreed. At least for devices with a single dedicated reset line this
would be a much better API.

regards
Philipp



More information about the devicetree-discuss mailing list