[PATCH 1/9] sh-pfc: Add OF support

Laurent Pinchart laurent.pinchart at ideasonboard.com
Tue Jan 8 05:56:19 EST 2013


Hi Tony,

On Friday 04 January 2013 14:12:06 Tony Prisk wrote:
> On Fri, 2013-01-04 at 01:40 +0100, Laurent Pinchart wrote:
> > +- #gpio-cells: Should be 2. The first cell is the pin number and the
> > second cell
> > +  is used to specify optional parameters (currently unused).
> 
> ...
> 
> > +	gpio: pfc at e6050000 {
> > +		compatible = "renesas,pfc-sh73a0";
> > +		reg = <0xe6050000 0x8000>,
> > +		      <0xe605801c 0x1c>;
> > +		gpio-controller;
> > +		#gpio-cells = <2>;
> > +	};
> > +
> > +Example 2: A GPIO LED node that references a GPIO
> > +
> > +	leds {
> > +		compatible = "gpio-leds";
> > +		led1 {
> > +			gpios = <&gpio 20 1>; /* Active low */
> > +		};
> > +	};
> > +
> 
> The second cell of gpio is '(currently unused)' but the example shows it
> being used?

My bad. The second cell can be used to specify that the GPIO is active low. 
I'll fix the documentation accordingly.

-- 
Regards,

Laurent Pinchart



More information about the devicetree-discuss mailing list