[PATCH 3/5 v7][RFC] ASoC: simple-card: add Device Tree support

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Thu Feb 28 11:53:23 EST 2013


Hi Stephen

Thank you for your reply

> > Support for loading the simple-card module via devicetree.
> > It requests cpu/codec information,
> > and .of_xlate_dai_name support on each driver for probing.
> 
> > diff --git a/Documentation/devicetree/bindings/sound/simple-card.txt b/Documentation/devicetree/bindings/sound/simple-card.txt
> 
> 
> > +Optional properties:
> ...
> > +- simple-audio,bitclock-inversion	: bit clock inversion for both CPU/CODEC
> > +- simple-audio,frame-inversion		: frame inversion for both CPU/CODEC
> 
> I think that Mark pointed out those would be best stored in the CPU and
> CODEC child nodes, since random buffering/inverting on the board might
> make the values at the two DAIs the opposite of each-other.

Sub node has same properties too,
and this is hybrid result of your/Mark comments.

If "sound node" has these properties, these will go to both CPU/CODEC,
this means "cpu/codec common properties"
if "cpu/codec sub node" has it, it will go to itself only.
I guess "common property" is useful ?

Thank you for other comments,
I will fix these in next version.
But I'm busy now, so, it will be next week.


Best regards
---
Kuninori Morimoto


More information about the devicetree-discuss mailing list