[PATCH 1/5 v7][RFC] ASoC: add snd_soc_register_cpu()

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Thu Feb 28 11:42:35 EST 2013


Hi Stephen

> On 02/25/2013 01:51 AM, Kuninori Morimoto wrote:
> > Current ASoC has register function for platform/codec/dai/card,
> > but doesn't have for cpu.
> > It often produces confusion and fault on ASoC.
> > This patch adds very basic register function for cpu
> 
> This seems reasonable to me.
> 
> I can't recall how much influence the existing CODEC objects have on the
> various routing/matching decisions inside the ASoC core. While this
> patch does register and unregister CPU objects, I wonder if it should
> have more impact on any of the existing core code? Certainly I'd expect
> the CPU objects to show up in ASoC's debugfs and any similar files...

This patch doesn't have any impact to existing drivers.
It just added new cpu list.

> So as far as it goes,
> Reviewed-by: Stephen Warren <swarren at nvidia.com>
> 
> But I suspect this patch might need to do a bunch of other stuff too, or
> add a bunch of follow-on patches for that?

If Mark can accept this new feature (= register CPU),
I think we can start to switch to use it.
But current struct CPU is very very simple, and it doesn't have any effect for existing code

Best regards
---
Kuninori Morimoto


More information about the devicetree-discuss mailing list