[alsa-devel] [PATCH 1/4 v6] ASoC: add .of_xlate_dai_name callback on struct snd_soc_dai_driver

[Kuninori Morimoto]

Hi Lars

Thank you for checking patch

> > +	list_for_each_entry(dai, &dai_list, list) {
> > +		if (dai->dev->of_node != args.np)
> > +			continue;
> > +
> > +		if (dai->driver->of_xlate_dai_name) {
> > +			name = dai->driver->of_xlate_dai_name(dai, &args);
> > +			if (name)
> > +				return name;
> > +		}
> 
> Hm, this is not really a translate function, but rather a match function. It
> iterates over all dais of the device and returns the name of the first one
> which matches. But there is no translation going on. If the dai matches the
> callback will always want to return dai->driver->name. Anything else doesn't
> make much sense.

I re-consider this including Stephen's opinion.
Thank you

Best regards
---
Kuninori Morimoto