[PATCH V6 02/10] ASoC: SAMSUNG: Add DT support for i2s

[Sylwester Nawrocki]

On 02/14/2013 12:43 PM, Mark Brown wrote:
> On Thu, Feb 14, 2013 at 11:48:59AM +0100, Sylwester Nawrocki wrote:
>
>> NAK.
>
>> Why we should live with this temporary code when there is already
>> pinctrl support for Exynos SoCs ?
>
>> If the pinctrl driver for Exynos5 was updated you could instead just do
>
>> devm_pinctrl_get_select_default(&i2s->pdev->dev);
>
> Too late, this stuff is already merged and on its way upstream.

My apologies for the late review. It's already sixth version of this patch
series... But I noticed it just now when applying it for Exynos4. The GPIO
part of the bindings is now incompatible with Exynos4 and the bindings will
need to be changed. Leaving the compatibility code in the I2S driver, when
we could have it done well right from the beginning. If I'm not mistaken
a file similar to arch/arm/boot/dts/exynos4x12-pinctrl.dtsi with at least
entries for the I2S devices is needed and an addition of related pinctrl
nodes in exynos5250.dtsi. But I guess this is not something that could be
fixed in the -rc period ?