[PATCH V2 1/3] of/selftest: Fix GPIOs selftest to cover the 7th case

Grant Likely grant.likely at secretlab.ca
Wed Feb 13 04:59:39 EST 2013


The of_gpio_named_count() self test doesn't hit the out-of-range
condition even though it is coded. Fix the bug by increasing the for
loop range by one.

Reported-by: Andreas Larsson <andreas at gaisler.com>
Cc: Rob Herring <rob.herring at calxeda.com>
Signed-off-by: Grant Likely <grant.likely at secretlab.ca>
---
 drivers/of/selftest.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/of/selftest.c b/drivers/of/selftest.c
index f24ffd7..9f62eb5 100644
--- a/drivers/of/selftest.c
+++ b/drivers/of/selftest.c
@@ -35,7 +35,7 @@ static void __init of_selftest_parse_phandle_with_args(void)
 		return;
 	}
 
-	for (i = 0; i < 7; i++) {
+	for (i = 0; i < 8; i++) {
 		bool passed = true;
 		rc = of_parse_phandle_with_args(np, "phandle-list",
 						"#phandle-cells", i, &args);
-- 
1.7.10.4



More information about the devicetree-discuss mailing list