[PATCH v4 2/2] iio: Add OF support

[Jonathan Cameron]

On 07/02/13 01:53, Guenter Roeck wrote:
> On Wed, Feb 06, 2013 at 07:37:37PM +0000, Jonathan Cameron wrote:
>> On 02/06/2013 06:29 PM, Guenter Roeck wrote:
>>> Provide bindings and parse OF data during initialization.
>>>
>>> Signed-off-by: Guenter Roeck <linux at roeck-us.net>
>> looks good to me.  Couple of little queries inline.
>>
> [ ... ]
>
>>> +
>>> +Example for a configuration with trigger:
>>> +
>>> +	adc at 35 {
>>> +		compatible = "maxim,max1139";
>>> +		reg = <0x35>;
>>> +
>>> +		adc: iio-device {
>>> +			#io-channel-cells = <1>;
>>> +		};
>>> +		trigger: iio-trigger {
>>> +			#io-channel-cells = <1>;
>> Why would the trigger have channel-cells?
>> So far we don't have any device tree stuff for the triggers.
>
> I thought about keeping the example and adding a note that trigger support is
> not currently implemented, but a better idea is to replace it with a second iio
> device. I'll do that unless someone objects.
>
> 	adc at 35 {
> 		compatible = "some-vendor,some-adc";
> 		reg = <0x35>;
>
> 		adc1: iio-device at 0 {
> 			#io-channel-cells = <1>;
> 			/* other properties */
> 		};
> 		adc2: iio-device at 1 {
> 			#io-channel-cells = <1>;
> 			/* other properties */
> 		};
> 	};
Agreed.

>
>>> +
>>> +==Example==
>>> +
>>> +	adc: max1139 at 35 {
>>> +		compatible = "maxim,max1139";
>>> +		reg = <0x35>;
>>> +		#io-channel-cells = <1>;
>>> +	};
>>> +
>>> +	...
>>> +
>>> +	iio_hwmon {
>>> +		compatible = "iio-hwmon";
>>> +		io-channels = <&adc 0>, <&adc 1>, <&adc 2>,
>>> +			<&adc 3>, <&adc 4>, <&adc 5>,
>>> +			<&adc 6>, <&adc 7>, <&adc 8>,
>>> +			<&adc 9>, <&adc 10>, <&adc 11>;
>>> +		io-channel-names = "vcc", "vdd", "vref", "1.2V";
>> This example still seems a little odd. Why give one where there are
>> more channels than names?
>
> I replaced the example with
>
> 	iio_hwmon {
> 		compatible = "iio-hwmon";
> 		io-channels = <&adc 0>, <&adc 1>, <&adc 2>,
> 			<&adc 3>, <&adc 4>, <&adc 5>,
> 			<&adc 6>, <&adc 7>, <&adc 8>,
> 			<&adc 9>;
> 		};
>
> 	some_consumer {
> 		compatible = "some-consumer";
> 		io-channels = <&adc 10>, <&adc 11>;
> 		io-channel-names = "adc1", "adc2";
> 	};
Good as well. Much happier with these examples as they
won't cause any confusion.
>
> Guenter
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>