[PATCH RFC 2/7] net: smsc911x: add pinctrl support

[Javier Martinez Canillas]

On Mon, Feb 11, 2013 at 3:23 PM, Linus Walleij <linus.walleij at linaro.org> wrote:
> On Sat, Feb 9, 2013 at 9:44 PM, Javier Martinez Canillas
> <javier.martinez at collabora.co.uk> wrote:
>
>> If no pinctrl is available just report a warning since
>> it may not needed in some cases (e.g: non-DT kernels).
>>
>> Signed-off-by: Javier Martinez Canillas <javier.martinez at collabora.co.uk>
> (...)
>> +       struct pinctrl *pinctrl;
> (...)
>> +       pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
>> +       if (IS_ERR(pinctrl)) {
>> +               retval = PTR_ERR(pinctrl);
>> +               if (retval == -EPROBE_DEFER)
>> +                       goto out_0;
>> +
>> +               dev_warn(&pdev->dev, "No pinctrl provided\n");
>> +       }
>
> NACK.
>
> This will be handled from the device core after the v3.9 merge
> window.
>
> See:
> http://marc.info/?l=linux-kernel&m=135887740715083&w=2
>

Great, I also wondered why it couldn't be part of the device core
since we basically duplicate this in all the DT aware drivers and
pinctrl was not used anywhere after setting to its default state.

This is a nice improvement.

> Yours,
> Linus Walleij
> --

Thanks a lot and best regards,
Javier