[PATCH 04/10] util_version: new helper for displaying version info

David Gibson david at gibson.dropbear.id.au
Mon Apr 29 20:55:16 EST 2013


On Mon, Apr 22, 2013 at 05:19:41PM -0400, Mike Frysinger wrote:
> On Thursday 18 April 2013 20:50:46 David Gibson wrote:
> > On Mon, Apr 15, 2013 at 10:13:11PM -0400, Mike Frysinger wrote:
> > > This is so all utilities can have this flag and not just dtc.
> > > 
> > > Acked-by: David Gibson <david at gibson.dropbear.id.au>
> > > Signed-off-by: Mike Frysinger <vapier at gentoo.org>
> > 
> > Please apply these first 4 patches, regardless of the rest of the
> > series.
> 
> on the subject of the other patches, is there a way i could split them up 
> that'd make things more palatable ?  the usage clean up ones could be merged 
> independently of the new fdtdump options.

I don't think there's anything really wrong with the split - it's just
they're a little more involved, and so it's taken me longer to look
through them properly.  In particular I've taken a bid of a sidetrack
working out what is broken for our build on freebsd at the moment and
fixing that to see how these patches affect it.

> clean up series:
> fdtdump: make usage a bit more friendly
> dtc/fdt{get,put}/convert-dtsv0-lexer: convert to new usage helpers
> util: drop "long" from usage helpers
> util: add common ARRAY_SIZE define
> 
> new functionality series:
> fdtdump: add a --scan option
> fdtdump: add a debug mode

I don't think it makes a big difference, and two series kind of
complicates things.  That order is a bit better than the original, at
least if you pull ARRAY_SIZE out to the front (I'd like to see that go
in right now, actually).

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.ozlabs.org/pipermail/devicetree-discuss/attachments/20130429/1564e4b1/attachment.sig>


More information about the devicetree-discuss mailing list