[PATCH V3] of: Set the DMA mask to 64 bits when dma_addr_t is 64-bits

Catalin Marinas catalin.marinas at arm.com
Sat Apr 27 06:52:00 EST 2013


On Fri, Apr 26, 2013 at 09:31:06PM +0100, Laura Abbott wrote:
> Currently, of_platform_device_create_pdata always sets the
> coherent DMA mask to 32 bits. On ARM systems without CONFIG_ZONE_DMA,
> arm_dma_limit gets set to ~0 or 0xFFFFFFFFFFFFFFFF on LPAE based
> systems. Since arm_dma_limit represents the smallest dma_mask
> on the system, the default of 32 bits prevents any dma_coherent
> allocation from succeeding unless clients manually set the
> dma mask first. Rather than make every client on an LPAE system set
> the mask manually, account for the size of dma_addr_t when setting
> the coherent mask.
> 
> Signed-off-by: Laura Abbott <lauraa at codeaurora.org>

Looks good.

Acked-by: Catalin Marinas <catalin.marinas at arm.com>


More information about the devicetree-discuss mailing list