[PATCH 6/6] thermal:exynos4: Add documentation for Exynos SoC thermal bindings

[Sachin Kamat]

Hi Lukasz,

Thanks for adding this. Some comments inline.

On 19 April 2013 22:08, Lukasz Majewski <l.majewski at samsung.com> wrote:
> Proper description for Exynos4 bindings added to Documentation/devicetree/
> bindings
>
> Signed-off-by: Lukasz Majewski <l.majewski at samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park at samsung.com>
> ---
>  .../devicetree/bindings/thermal/exynos-thermal.txt |   22 ++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/thermal/exynos-thermal.txt
>
> diff --git a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
> new file mode 100644
> index 0000000..e994e1e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
> @@ -0,0 +1,22 @@
> +* Exynos Thermal

How about "Exynos Thermal Management Unit (TMU)"?

> +
> +Required properties:
> +- compatible : "samsung,exynos4412-tmu"
Should be one of the following:
"samsung,exynos4210-tmu"
"samsung,exynos4412-tmu"
"samsung,exynos5250-tmu"


> +- interrupts-parent : The phandle for the interrupt controller

s/interrupts-parent /interrupt-parent


> +- reg : Address range of the thermal registers
> +- interrupts : Should contain interrupt for thermal system
> +- clocks : The main clock for TMU device
> +- clocks-names : Thermal system clock name

s/clocks-names /clock-names
You may also choose to add "from common clock binding" for clocks and
clock-names properties above.

> +- status : Initial state of the device
You may remove this as it is quite obvious now. Even if you want to
retain this, it should be under 'Optional properties:'


-- 
With warm regards,
Sachin