[PATCH v2 0/3] drm/exynos: Add device tree support for IPP driver

[Inki Dae]

Hi Sylwester,

DRM FIMC driver could be more cleaned up with this patch series. And your
third patch
And just minor issue. The second patch has build warnings like below,

WARNING: static const char * array should probably be static const char *
const
#111: FILE: drivers/gpu/drm/exynos/exynos_drm_fimc.c:89:
+static const char * fimc_clock_names[] = {

ERROR: "foo * bar" should be "foo *bar"
#111: FILE: drivers/gpu/drm/exynos/exynos_drm_fimc.c:89:


This is a minor issue so I can fix them. And as you already know, now drm
fimc driver should be more cleaned up. Your patch set looks good to me but
I'd like to take more opinions from others.

And you can find my comments at the third patch.

Thanks,
Inki Dae



2013/4/17 Sylwester Nawrocki <s.nawrocki at samsung.com>

> Hi Inki,
>
> This small patch series adds device tree support for the DRM FIMC driver.
> The binding documentation can be found in -next at
> Documentation/devicetree/
> bindings/media/samsung-fimc.txt.
> It will make the driver dependent on OF. This patch series is needed in
> 3.10 to ensure simultaneous operation of the DRM FIMC and the camera ISP
> on Exynos4x12.
>
> Changes since v1:
>  - removed devm_kfree() that got erroneously re-added in patch 2/3 during
>    rebase.
>
> Thanks,
> Sylwester
>
> Sylwester Nawrocki (3):
>   drm/exynos: Remove redundant devm_kfree()
>   drm/exynos: Rework fimc clocks handling
>   drm/exynos: Add device tree support for fimc ipp driver
>
>  drivers/gpu/drm/exynos/Kconfig           |    2 +-
>  drivers/gpu/drm/exynos/exynos_drm_fimc.c |  264
> ++++++++++++++++--------------
>  drivers/gpu/drm/exynos/regs-fimc.h       |    7 +-
>  3 files changed, 147 insertions(+), 126 deletions(-)
>
> --
> 1.7.9.5
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/devicetree-discuss/attachments/20130421/480a5062/attachment-0001.html>