[PATCH RFC 2/2] gpio: samsung: Remove OF support for Exynos4/5

Linus Walleij linus.walleij at linaro.org
Thu Apr 18 02:35:34 EST 2013


On Wed, Apr 17, 2013 at 1:06 PM, Sylwester Nawrocki
<s.nawrocki at samsung.com> wrote:

> -#endif
> +        * All Samsung platforms that support device tree will use the pinctrl
> +        * driver, hence we skip initialization of this driver if the OF tree
> +        * is available.
> +        */
> +       if (of_have_populated_dt())
> +               return -ENODEV;
>
>         samsung_gpiolib_set_cfg(samsung_gpio_cfgs, ARRAY_SIZE(samsung_gpio_cfgs));

Oh is that how you do it? It looks fragile.

Can't you check if you have the pinctrl node atleast?

Yours,
Linus Walleij


More information about the devicetree-discuss mailing list