[PATCH V2 3/3] power: power_supply_core: Add support for supplied_from

Anton Vorontsov anton at enomsg.org
Wed Apr 17 11:55:49 EST 2013


On Mon, Apr 01, 2013 at 05:45:55PM -0400, Rhyland Klein wrote:
> Adding support for supplied_from char * array. This is meant to store the
> list of suppliers for a given supply, i.e. chargers for a battery. This
> list can be populated through devicetree readily as well as passed
> directly from the driver.

The subject doesn't quite reflect the content of the patch... but I fixed
it up.

> +int power_supply_populate_supplied_from(struct power_supply *psy)
> +{

This gives me:

  CHECK   drivers/power/power_supply_core.c
drivers/power/power_supply_core.c:119:5: warning: symbol 'power_supply_populate_supplied_from' was not declared. Should it be static?
drivers/power/power_supply_core.c:144:5: warning: symbol 'power_supply_find_supply_from_node' was not declared. Should it be static?
drivers/power/power_supply_core.c:173:5: warning: symbol 'power_supply_check_supplies' was not declared. Should it be static?

I fixed it up by making the functions static. Once you need the functions
outside of _core.c, feel free to export them.

Thanks,

Anton


More information about the devicetree-discuss mailing list