[PATCH v3 05/15] ASoC: phycore-ac97: Add DT support
Markus Pargmann
mpa at pengutronix.de
Wed Apr 17 01:23:05 EST 2013
On Tue, Apr 16, 2013 at 12:59:43PM +0100, Mark Brown wrote:
> On Sun, Apr 14, 2013 at 01:42:49PM +0200, Markus Pargmann wrote:
>
> > + /*
> > + * This driver doesn't need to know which actual hardware is used.
> > + * The audmux driver has knowledge about it's type, and returns
> > + * an error if executed on the wrong type of hardware.
> > + */
> > + ret = phycore_ac97_pca100_audmux();
> > + if (!ret)
> > + return 0;
> > +
> > + ret = phycore_ac97_pcm043_audmux();
>
> The DT really ought to be able to give enough information to figure out
> the audmux configuration. If we can't do that it rather defeats the
> point of moving to DT...
Yes you are right, I added a phandle "phytec,audmux" to check which
audmux setup function we have to use.
Regards,
Markus
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
More information about the devicetree-discuss
mailing list