[PATCH 00/10 v3] usage()/--help clean up & unification, and extend fdtdump
Mike Frysinger
vapier at gentoo.org
Tue Apr 16 12:13:07 EST 2013
Each utility currently open codes how they process options and
implement usage(). This leads to inconsistent behavior and output
which sucks. A bunch also get common things wrong (like sending
--help to stderr).
Rather than go through them one by one and fix their bugs, start
a new mini framework in the util.[ch] code base. This allows the
utils to be much more data driven in their approach to options --
they declare certain structures with the right format, and then
call usage() as needed. The new util code takes care of the rest.
I also snuck in a few minor fixes in this patch series that I
noticed as I was hacking on things. Really I just wanted --scan
and --debug options in the fdtdump tool :).
I've made sure each patch builds & passes `make check` by itself.
So things should be git bisectable.
For the v3 series:
- add dedicated _len read helpers rather than rework existing ones
- rename dprintf() to dumpf() in fdtdump
Mike Frysinger (10):
utilfdt_read_err: use xmalloc funcs
utilfdt_read: pass back up the length of data read
die: constify format string arg
util_version: new helper for displaying version info
fdtdump: make usage a bit more friendly
fdtdump: add a --scan option
dtc/fdt{get,put}/convert-dtsv0-lexer: convert to new usage helpers
util: drop "long" from usage helpers
util: add common ARRAY_SIZE define
fdtdump: add a debug mode
convert-dtsv0-lexer.l | 24 +++++++----
dtc.c | 116 +++++++++++++++++++++++++-------------------------
dtc.h | 1 -
fdtdump.c | 110 ++++++++++++++++++++++++++++++++++++++++++-----
fdtget.c | 60 ++++++++++++--------------
fdtput.c | 63 +++++++++++++--------------
util.c | 84 +++++++++++++++++++++++++++++++++---
util.h | 85 +++++++++++++++++++++++++++++++++++-
8 files changed, 393 insertions(+), 150 deletions(-)
--
1.8.1.2
More information about the devicetree-discuss
mailing list