[BUG] omap: mfd/regulator: twl/core: init order

Tony Lindgren tony at atomide.com
Tue Apr 16 02:25:42 EST 2013


* Grygorii Strashko <grygorii.strashko at ti.com> [130415 04:05]:
> On 04/15/2013 01:56 PM, Christoph Fritz wrote:
> >On Mon, 2013-04-15 at 13:20 +0300, Grygorii Strashko wrote:
> >>--- a/drivers/pinctrl/pinctrl-single.c
> >>+++ b/drivers/pinctrl/pinctrl-single.c
> >>@@ -1014,7 +1014,18 @@ static struct platform_driver pcs_driver = {
> >>          },
> >>   };
> >>
> >>-module_platform_driver(pcs_driver);
> >>+static int __init pcs_driver_drv_init(void)
> >>+{
> >>+       return platform_driver_register(&pcs_driver);
> >>+}
> >>+postcore_initcall(pcs_driver_drv_init);
> >>+
> >>+static void __exit pcs_driver_drv_exit(void)
> >>+{
> >>+       platform_driver_unregister(&pcs_driver);
> >>+}
> >>+module_exit(pcs_driver_drv_exit);
> >>+
> >Hi Grygorii,
> >  thanks - indeed it does fix the problem. I checked at least the rtc
> >which is now configured right and working :-)
> >
> >Do you consider the patch above as a hack or will it go mainline?
> I think, need more opinions on this from community )
> I'm just trying to solve my problem and found similar issue.

This fix should not be needed. It just means the real
problem is somewhere else. Pinctrl is already before the i2c
in drivers/Makefile. Maybe one of the MFD drivers has
a wrong initcall level?

Regards,

Tony


More information about the devicetree-discuss mailing list