[PATCH 2/2] ARM: dts: Update MFC documentation for clock entries

[Sachin Kamat]

Hi Sylwester,

Thanks for your review.

On 4 April 2013 16:38, Sylwester Nawrocki <s.nawrocki at samsung.com> wrote:
> On 04/04/2013 08:26 AM, Sachin Kamat wrote:
>> Added clock entry definitions to MFC bindings document.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat at linaro.org>
>> ---
>>  .../devicetree/bindings/media/s5p-mfc.txt          |    5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/media/s5p-mfc.txt b/Documentation/devicetree/bindings/media/s5p-mfc.txt
>> index bf0182d..d7b991a 100644
>> --- a/Documentation/devicetree/bindings/media/s5p-mfc.txt
>> +++ b/Documentation/devicetree/bindings/media/s5p-mfc.txt
>> @@ -15,6 +15,9 @@ Required properties:
>>         mapped region.
>>
>>    - interrupts : MFC interrupt number to the CPU.
>> +  - clocks: from common clock binding: handle to mfc clocks.
>> +  - clock-names: from common clock binding: Shall be "sclk_mfc" and "mfc"
>> +              for "samsung,mfc-v5".
>
> Not sure if we shouldn't be more specific about the fact the entries in
> the clocks property must be in same order as names in clock-names. Perhaps
> it's sufficient you mentioned the common clock binding which defines that.

Right.

> Also we should keep the clock names same, regardless which MFC IP version
> those apply to. At least as far as same driver is used for them and the
> number of clocks is same. Thus perhaps this could be:

Right. Since mfc-v6 currently took aclk_333 as second clk instead of
sclk_mfc, I made the description specific to mfc-v5.

>
> - clock-names : from common clock binding: must contain "sclk_mfc" and "mfc",
>         corresponding to entries in the clocks property.

I will update as above.

>
> Please note there is a white space before the first colon, that makes
> it really an important improvement...

Ok.

>
> Please feel free to add my
>
> Reviewed-by: Sylwester Nawrocki <s.nawrocki at samsung.com>
>
> with those issues addressed.

Thanks.



-- 
With warm regards,
Sachin