[PATCH v4 04/14] mfd: Add Samsung PWM/timer master driver
Samuel Ortiz
sameo at linux.intel.com
Sat Apr 6 03:39:58 EST 2013
Hi Tomasz,
On Thu, Apr 04, 2013 at 06:37:01PM +0200, Tomasz Figa wrote:
> This patch adds master driver for PWM/timer block available on many
> Samsung SoCs providing clocksource and PWM output capabilities.
>
> Signed-off-by: Tomasz Figa <t.figa at samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park at samsung.com>
> ---
> .../devicetree/bindings/pwm/pwm-samsung.txt | 37 ++
> drivers/clocksource/Kconfig | 1 +
> drivers/mfd/Kconfig | 3 +
> drivers/mfd/Makefile | 1 +
> drivers/mfd/samsung-pwm.c | 439 +++++++++++++++++++++
> drivers/pwm/Kconfig | 1 +
> include/linux/mfd/samsung-pwm.h | 49 +++
> include/linux/platform_data/samsung-pwm.h | 28 ++
> 8 files changed, 559 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pwm/pwm-samsung.txt
> create mode 100644 drivers/mfd/samsung-pwm.c
> create mode 100644 include/linux/mfd/samsung-pwm.h
> create mode 100644 include/linux/platform_data/samsung-pwm.h
Why is that an MFD driver, and why aren't you using the PWM APIs for it ?
Also, you probably want to look at using the regmap APIs for your IO.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
More information about the devicetree-discuss
mailing list