[PATCH v2] ARM: dts: Add SYSREG block node for S5P/Exynos4 SoC series

Kukjin Kim kgene.kim at samsung.com
Tue Apr 2 20:47:33 EST 2013


Sylwester Nawrocki wrote:
> 
> This patch adds device tree node for the SYSREG registers block
> found in Samsung S5P/Exynos SoC series. The SYSREG module
> generates control signals for the ARM CPU and various IP blocks
> and buses. SYSREG block registers are exposed through APB bus
> interface. A sysreg device tree node is to be associated with
> mfd syscon driver and all SYSREG clients should use regmap
> interface it provides. It allows to eliminate any possible races
> and conflicts should different drivers attempt to concurrently
> access same register.
> 
> Signed-off-by: Sylwester Nawrocki <s.nawrocki at samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park at samsung.com>
> ---
> 
> Changes since v1:
>  - Added missing "samsung," prefix to the compatible property,
>  - the binding documentation moved to ...bindings/arm/samsung
>    as SYSREG block can be also found on other SoCs than Exynos.
> ---
>  .../devicetree/bindings/arm/samsung/sysreg.txt     |    7 +++++++
>  arch/arm/boot/dts/exynos4.dtsi                     |    5 +++++
>  2 files changed, 12 insertions(+)
>  create mode 100644
> Documentation/devicetree/bindings/arm/samsung/sysreg.txt
> 
> diff --git a/Documentation/devicetree/bindings/arm/samsung/sysreg.txt
> b/Documentation/devicetree/bindings/arm/samsung/sysreg.txt
> new file mode 100644
> index 0000000..5039c0a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/samsung/sysreg.txt
> @@ -0,0 +1,7 @@
> +SAMSUNG S5P/Exynos SoC series System Registers (SYSREG)
> +
> +Properties:
> + - name : should be 'sysreg';
> + - compatible : should contain "samsung,<chip name>-sysreg", "syscon";
> +   For Exynos4 SoC series it should be "samsung,exynos4-sysreg",
"syscon";
> + - reg : offset and length of the register set.
> diff --git a/arch/arm/boot/dts/exynos4.dtsi
> b/arch/arm/boot/dts/exynos4.dtsi
> index 9ac47d5..462f055 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -82,6 +82,11 @@
>  		reg = <0x10440000 0x1000>;
>  	};
> 
> +	sys_reg: sysreg {
> +		compatible = "samsung,exynos4-sysreg", "syscon";
> +		reg = <0x10010000 0x400>;
> +	};
> +
>  	watchdog at 10060000 {
>  		compatible = "samsung,s3c2410-wdt";
>  		reg = <0x10060000 0x100>;
> --
> 1.7.9.5

Looks ok to me, applied.

Thanks.

- Kukjin



More information about the devicetree-discuss mailing list