[PATCH v2 4/5] mmc: mxcmmc: enable DMA support on mpc512x

[Sascha Hauer]

On Tue, Apr 02, 2013 at 09:29:44AM +0200, Anatolij Gustschin wrote:
> On Tue, 2 Apr 2013 08:56:54 +0200
> Sascha Hauer <s.hauer at pengutronix.de> wrote:
> ...
> > > @@ -336,6 +359,8 @@ static int mxcmci_setup_data(struct mxcmci_host *host, struct mmc_data *data)
> > >  	} else {
> > >  		host->dma_dir = DMA_TO_DEVICE;
> > >  		slave_dirn = DMA_MEM_TO_DEV;
> > > +
> > > +		mxcmci_fixup_buffers(data);
> > 
> > For the register accesses it's fine the way you did in this version, but
> > here I think a
> > 
> > 	if (is_mpc512x_mmc())
> > 		swap_buffer()
> > 
> > would look better.
> 
> the swapping function uses optimised st_le32() which is not available
> on ARM, that's the reason why this is build time selected.

Ah, ok. I think it's fine then.

> Maybe the
> "fixup" in the function name is not pretty, I can change it to "swap"
> then.

Yes, that would be better.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |