[PATCH V3] video: exynos_dp: Add device tree support to DP driver

Jingoo Han jg1.han at samsung.com
Fri Sep 28 18:09:28 EST 2012


On Friday, September 28, 2012 3:48 PM Tomasz Figa wrote
> 
> Hi,
> 
> On Friday 28 of September 2012 09:11:09 Jingoo Han wrote:
> > On Thursday, September 27, 2012 10:45 PM Sylwester Nawrocki wrote
> > > > +Example:
> > > > +
> > > > +SOC specific portion:
> > > > +	dptx_phy: dptx_phy at 0x10040720 {
> > > > +		compatible = "samsung,dp-phy";
> > > > +		samsung,dptx_phy_reg =<0x10040720>;
> > > > +		samsung,enable_bit =<1>;
> > > > +	};
> > > > +
> > > > +	display-port-controller {
> > > > +		compatible = "samsung,exynos5-dp";
> > > > +		reg =<0x145B0000 0x10000>;
> > > > +		interrupts =<10 3>;
> > > > +		interrupt-parent =<&combiner>;
> > > > +		dp_phy =<&dptx_phy>;
> > >
> > > Shouldn't it be "samsung,dp_phy" ?
> >
> > Do you mean this ? It is not working.
> > +		dp_phy = "samsung,dp_phy";
> 
> I believe he meant:
> 
> -+		dp_phy =<&dptx_phy>;
> ++		samsung,dp_phy =<&dptx_phy>;
> 
> to mark that this is a Samsung-specific property.

Oh, I see.
Yes, "samsung,dp_phy =<&dptx_phy>" is right.
As you mentioned, this is a Samsung-specific property.
Thank you.


Best regards,
Jingoo Han

> 
> Best regards,
> Tomasz Figa



More information about the devicetree-discuss mailing list