[PATCH v4] ARM: EXYNOS: Add MFC device tree support

[Kukjin Kim]

Karol Lewandowski wrote:
> 
> On 09/22/2012 08:07 PM, Arun Kumar K wrote:
> 
> > This patch adds device tree entry for MFC v6 in the Exynos5
> > SoC. Makes the required changes in the clock files and adds
> > MFC to the DT device list.
> >
> > Signed-off-by: Naveen Krishna Chatradhi <ch.naveen at samsung.com>
> > Signed-off-by: Arun Kumar K <arun.kk at samsung.com>
> 
> 
> Looks good for me. FWIW, I could probably add
> 
> Acked-by: Karol Lewandowski <k.lewandowsk at samsung.com>
> 
Happens following build error with exynos4_defconfig because of non-DT ?

arch/arm/mach-exynos/common.c: In function 'exynos_fdt_find_mfc_mem':
arch/arm/mach-exynos/common.c:1058: error: implicit declaration of function 'of_flat_dt_is_compatible'
arch/arm/mach-exynos/common.c:1061: error: implicit declaration of function 'of_get_flat_dt_prop'
arch/arm/mach-exynos/common.c:1061: warning: assignment makes pointer from integer without a cast
arch/arm/mach-exynos/common.c:1064: error: implicit declaration of function 'of_read_ulong'
arch/arm/mach-exynos/common.c:1066: warning: assignment makes pointer from integer without a cast
arch/arm/mach-exynos/common.c:1071: warning: assignment makes pointer from integer without a cast
arch/arm/mach-exynos/common.c:1076: warning: assignment makes pointer from integer without a cast
make[1]: *** [arch/arm/mach-exynos/common.o] Error 1

And I think, firstly we could move the function exynos_fdt_find_mfc_mem() into plat-samsung/ for using on other Samsung stuff such as s5pv210 and need to enclose '#ifdef CONFIG_OF" for non-DT?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.