[PATCH V5 1/2] of: Add generic device tree DMA helpers

Jon Hunter jon-hunter at ti.com
Sat Sep 15 03:20:45 EST 2012


On 09/14/2012 10:26 AM, Arnd Bergmann wrote:
> On Friday 14 September 2012, Jon Hunter wrote:
>>
>> Cc: Nicolas Ferre <nicolas.ferre at atmel.com>
>> Cc: Benoit Cousson <b-cousson at ti.com>
>> Cc: Stephen Warren <swarren at nvidia.com>
>> Cc: Grant Likely <grant.likely at secretlab.ca>
>> Cc: Russell King <linux at arm.linux.org.uk>
>> Cc: Rob Herring <rob.herring at calxeda.com>
>> Cc: Arnd Bergmann <arnd at arndb.de>
>> Cc: Vinod Koul <vinod.koul at intel.com>
>> Cc: Dan Williams <djbw at fb.com>
>> Signed-off-by: Jon Hunter <jon-hunter at ti.com>
> 
> Reviewed-by: Arnd Bergmann <arnd at arndb.de>
> 
> Thanks for all this work, looks great!

Thanks!

> My final (tiny) comment on this:
> 
>> +2. A single read-write channel with two alternative dma controllers:
>> +
>> +	dmas = <&dma1 5
>> +		&dma2 7
>> +		&dma3 2>;
>> +	dma-names = "rx-tx", "rx-tx", "rx-tx"
> 
> *three* alternative dma controllers, not two.

Oops! I have been starring at this so long I can no longer see the wood
for the trees!

Jon


More information about the devicetree-discuss mailing list