[PATCH v5 3/4] regulator: anatop-regulator: convert to use syscon to access anatop register

Dong Aisheng b29396 at freescale.com
Tue Sep 4 21:27:04 EST 2012


On Tue, Sep 04, 2012 at 07:34:32PM +0800, Shawn Guo wrote:
> On Tue, Sep 04, 2012 at 11:20:10AM +0800, Dong Aisheng wrote:
> > +
> > +	anatop_np = of_get_parent(np);
> > +	if (!anatop_np)
> > +		return -ENODEV;
> > +	sreg->anatop = syscon_node_to_regmap(anatop_np);
> > +	if (IS_ERR(sreg->anatop))
> > +		return PTR_ERR(sreg->anatop);
> > +
> With of_node_put moved out from syscon_node_to_regmap, shouldn't
> we put anatop_np here then?
> 
When i sent it out, i found i missed it...
Should be more care...

Regards
Dong Aisheng



More information about the devicetree-discuss mailing list