[PATCH V2 2/3] dmaengine: dw_dmac: Enhance device tree support

Andy Shevchenko andy.shevchenko at gmail.com
Sat Oct 13 02:53:19 EST 2012


On Fri, Oct 12, 2012 at 6:18 PM, Viresh Kumar <viresh.kumar at linaro.org> wrote:
> On 12 October 2012 20:28, Andy Shevchenko
> <andriy.shevchenko at linux.intel.com> wrote:
>> On Fri, 2012-10-12 at 20:01 +0530, Viresh Kumar wrote:
>
>>> +     if (last_dw) {
>>> +             if ((last_bus_id == param) && (last_dw == dw))
>>> +                     return false;
>>> +     }
1. This is an equivalent of
if (last_dw && (last_bus_id == ... ) && (last_dw == dw))
 return false;
2. In case dw is always non-NULL the last_dw == dw is false if last_dw is NULL.

Where am I wrong?

> You are already drunk.
Not yet, but tired.

-- 
With Best Regards,
Andy Shevchenko


More information about the devicetree-discuss mailing list