[PATCH v2 1/2] USB: Update EHCI-platform driver to devicetree.

Alan Stern stern at rowland.harvard.edu
Tue Oct 23 01:51:19 EST 2012


On Sun, 21 Oct 2012, Tony Prisk wrote:

> +static u64 ehci_dma_mask = DMA_BIT_MASK(32);

...

> +		/* Right now device-tree probed devices don't get dma_mask set.
> +		 * Since shared usb code relies on it, set it here for now.
> +		 * Once we have dma capability bindings this can go away.
> +		 */
> +		if (!dev->dev.dma_mask)
> +			dev->dev.dma_mask = &ehci_dma_mask;

Grant:

I have seen this sort of thing added to many drivers.  Why can't this 
be centralized in a way that will apply once and for all to all 
appropriate DT-based drivers?

Eventually DMA capabilities will be supported properly in DT, right?  
Then all these additions made to hundreds(?) of drivers will have to be
removed.  Why not start the ball rolling now and prevent things from
getting even worse?

Alan Stern



More information about the devicetree-discuss mailing list