[PATCH V5 1/2] video: exynos_dp: Add device tree support to DP driver

Sylwester Nawrocki sylvester.nawrocki at gmail.com
Sat Oct 13 09:14:39 EST 2012


On 10/12/2012 11:54 PM, Tomasz Figa wrote:
>>> +	if (of_get_property(dp_node, "interlaced", NULL))
>>> +		dp_video_config->interlaced = 1;
>>
>> of_property_read_bool() could also be used here.
> 
> Wouldn't it make the property mandatory?

No, it wouldn't. of_property_read_bool() uses of_find_property() 
internally. It just returns true if property is found or false 
otherwise. Anyway, it appears of_get_property(..., NULL) pattern
is commonly used for boolean properties.

> I would just use of_find_property here, instead of of_get_property.
> 
> Best regards,
> Tomasz Figa



More information about the devicetree-discuss mailing list