[PATCH 1/6] ARM: bcm476x: Add infrastructure
Domenico Andreoli
cavokz at gmail.com
Fri Oct 12 18:06:51 EST 2012
Thomas,
On Sun, Oct 07, 2012 at 03:53:01AM +0200, Domenico Andreoli wrote:
>
> Index: b/arch/arm/mach-bcm476x/bcm476x.c
> ===================================================================
> --- /dev/null
> +++ b/arch/arm/mach-bcm476x/bcm476x.c
...
> +
> +#define BCM476X_PERIPH_PHYS 0x00080000
> +#define BCM476X_PERIPH_VIRT 0xd0080000
Are you sure I should use IOMEM() here? The only place I use these macros
is here below, for which I should add a cast to silent the compiler. All
the other accesses go throught ioremap/readl/writel, if not I want to fix it.
> +
> +static struct map_desc io_map __initdata = {
> + .virtual = BCM476X_PERIPH_VIRT,
> + .pfn = __phys_to_pfn(BCM476X_PERIPH_PHYS),
> + .length = BCM476X_PERIPH_SIZE,
> + .type = MT_DEVICE,
> +};
Regards,
Domenico
More information about the devicetree-discuss
mailing list