[PATCH 2/5] ARM: S3C64XX: Add phy_type to pmu_isolation

kishon kishon at ti.com
Tue Oct 9 16:33:55 EST 2012


Hi,

On Monday 08 October 2012 07:42 PM, Vivek Gautam wrote:
> It adds 'type' argument to pmu_isolation function, aligning
> with other platforms, which keeps track of usbphy_type.
>
> Signed-off-by: Vivek Gautam <gautam.vivek at samsung.com>
> ---
>   arch/arm/mach-s3c64xx/setup-usb-phy.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-s3c64xx/setup-usb-phy.c b/arch/arm/mach-s3c64xx/setup-usb-phy.c
> index 3aee778..b7d1d95 100644
> --- a/arch/arm/mach-s3c64xx/setup-usb-phy.c
> +++ b/arch/arm/mach-s3c64xx/setup-usb-phy.c
> @@ -13,7 +13,7 @@
>   #include <mach/map.h>
>   #include <mach/regs-sys.h>
>
> -void s5p_usb_phy_pmu_isolation(int on)
> +void s5p_usb_phy_pmu_isolation(int on, int type)

IMO, this patch should have been squashed with the previous patch. IIUC, 
you have changed the call to this function for taking two arguments in 
your previous patch. Wouldn't that introduce compilation break after 
applying your first patch?

Thanks
Kishon


More information about the devicetree-discuss mailing list