[PATCH] devicetree: fsl.txt: Add an entry to mx27pdk board

Shawn Guo shawn.guo at linaro.org
Sun Oct 7 00:06:41 EST 2012


On Wed, Sep 26, 2012 at 09:19:15AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam at freescale.com>
> 
> Add an entry to mx27pdk board (or also known as mx27 3ds).
> 
> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
> ---
>  Documentation/devicetree/bindings/arm/fsl.txt |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.txt b/Documentation/devicetree/bindings/arm/fsl.txt
> index ac9e751..57dc148 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.txt
> +++ b/Documentation/devicetree/bindings/arm/fsl.txt
> @@ -5,6 +5,10 @@ i.MX23 Evaluation Kit
>  Required root node properties:
>      - compatible = "fsl,imx23-evk", "fsl,imx23";
>  
> +i.MX27 Product Development Kit

I'm wondering why fsl,imx27-pdk wasn't picked as the compatible string,
if Product Development Kit is the preferred name.

> +Required root node properties:
> +    - compatible = "fsl,imx27-3ds", "fsl,imx27";
> +

We have the following two lines in imx27-3ds.dts right now.

        model = "mx27_3ds";
        compatible = "freescale,imx27-3ds", "fsl,imx27";

The "model" property deserves a more descriptive string, while
"compatible" even needs a fixing, s/freescale/fsl.

>  i.MX28 Evaluation Kit
>  Required root node properties:
>      - compatible = "fsl,imx28-evk", "fsl,imx28";
> -- 
> 1.7.9.5
> 


More information about the devicetree-discuss mailing list