[PATCH v2] drivers/of: Constify device_node->name and ->path_component_name
Grant Likely
grant.likely at secretlab.ca
Fri Nov 30 03:34:16 EST 2012
On Wed, 28 Nov 2012 10:46:04 +1100, Michael Neuling <mikey at neuling.org> wrote:
> > Neither of these should ever be changed once set. Make them const and
> > fix up the users that try to modify it in-place. In one case
> > kmalloc+memcpy is replaced with kstrdup() to avoid modifying the string.
> >
> > Build tested with defconfigs on ARM, PowerPC, Sparc, MIPS, x86 among
> > others.
>
> Grant,
>
> This breaks powerpc chroma_defconfig in next-20121127 with:
>
> arch/powerpc/sysdev/scom.c:160:17: error: assignment discards 'const' qualifier from pointer target type [-Werror]
>
> The following fixes it. The change is to generic code, so I'm not sure
> it's the right fix as it may break other configs/archs.
That is rather risky. Post it as a patch to core code, but in the mean
time I'll patch the powerpc scom code.
g.
More information about the devicetree-discuss
mailing list