[PATCH 2/2] of/spi: Honour "status=disabled" property of device

Alexander Sverdlin asv at sysgo.com
Thu Nov 29 18:59:29 EST 2012


From: Alexander Sverdlin <alexander.sverdlin at sysgo.com>

of/spi: Honour "status=disabled" property of device

Currently of_register_spi_devices() function registers all SPI devices,
independetly from their status property in device tree. According to
"ePAPR 1.1" spec, device should only be registered if there is no
"status" property, or it has "ok" (or "okay") value (see
of_device_is_available()). In case of "platform devices",
of_platform_device_create_pdata() checks for "status" and ensures
that disabled devices are not pupulated. But such check for SPI buses
was missing until now. Fix it.

Signed-off-by: Alexander Sverdlin <alexander.sverdlin at sysgo.com>
---
--- linux.orig/drivers/spi/spi.c
+++ linux/drivers/spi/spi.c
@@ -819,7 +819,7 @@ static void of_register_spi_devices(stru
 	if (!master->dev.of_node)
 		return;
 
-	for_each_child_of_node(master->dev.of_node, nc) {
+	for_each_available_child_of_node(master->dev.of_node, nc) {
 		/* Alloc an spi_device */
 		spi = spi_alloc_device(master);
 		if (!spi) {


More information about the devicetree-discuss mailing list