[PATCH] of_i2c: Honour "status=disabled" property of device

Alexander Sverdlin asv at sysgo.com
Thu Nov 29 03:51:58 EST 2012


Hi!

On 11/28/2012 05:16 PM, Stephen Warren wrote:
> On 11/28/2012 07:21 AM, Alexander Sverdlin wrote:
>> of_i2c: Honour "status=disabled" property of device
>>
>> Currently of_i2c_register_devices() function registers all i2c devices,
>> independently from their status property in device tree. According to
>> "ePAPR 1.1" spec, device should only be registered if there is no
>> "status" property, or it has "ok" (or "okay") value (see
>> of_device_is_available()). In case of "platform devices",
>> of_platform_device_create_pdata() checks for "status" and ensures
>> that disabled devices are not populated. But such check for i2c buses
>> was missing until now. Fix it.
> 
> Do SPI and other buses (e.g. MDIO/MDIO mux?) need a similar change?

You are right, of_register_spi_devices() and of_mdiobus_register() both have exactly the same issue.
Should it be a follow-up patch, or better to combine them to one patch?

-- 
Best regards,
Alexander Sverdlin.


More information about the devicetree-discuss mailing list