[PATCH V3 3/3] mfd: stmpe: Update DT support in stmpe driver

Viresh Kumar viresh.kumar at linaro.org
Wed Nov 28 13:13:54 EST 2012


On 28 November 2012 01:25, Rabin Vincent <rabin at rab.in> wrote:
> 2012/11/27 Viresh Kumar <viresh.kumar at linaro.org>:
>> On 27 November 2012 14:10, Lee Jones <lee.jones at linaro.org> wrote:
>> I haven't seen this in any of SPEAr boards i have worked on. Maybe Rabin
>> would have, that's why he added that part of code :)
>>
>> @Rabin/Linus: Do you remember why have you added this in stmpe driver:
>>
>> +       if (stmpe->pdata->irq_invert_polarity)
>> +               icr ^= STMPE_ICR_LSB_HIGH;
>> +
>>
>> Does somebody actually need it?
>
> It was (as irq_rev_pol) part of Luotao Fu's proposed STMPE811 patchset
> (https://patchwork.kernel.org/patch/106173/) which I integrated into my
> version of the STMPE driver, which didn't have it in its initial version
> (https://patchwork.kernel.org/patch/103273/).
>
> It's not something _I_ ever used.

I grep'd kernel and nobody is using it there, so lets get rid of it
completely :)
I will patch it.

--
viresh


More information about the devicetree-discuss mailing list