[PATCH V5 5/5] arm: mvebu: Added SMP support for Armada XP

[Will Deacon]

On Wed, Nov 21, 2012 at 12:31:36PM +0000, Gregory CLEMENT wrote:
> On 11/21/2012 01:26 PM, Russell King - ARM Linux wrote:
> > On Wed, Nov 21, 2012 at 12:22:51PM +0000, Will Deacon wrote:
> >> Sorry, my mistake (I was thinking on my feet) since secondary_startup is
> >> declared in a C file, right? How about:
> >>
> >> 	ldr	lr, =secondary_startup
> >> 	b	ll_set_cpu_coherent
> > 
> > Why?  Do we really want LR to be the _virtual_ address?  No we don't,
> > because secondary_startup expects to be called with the MMU off.
> > 
> > So I go back to my original comment.  What's wrong with:
> > 
> > 	bl	ll_set_cpu_coherent
> > 	b	secondary_startup
> > 
> > ?
> 
> Nothing wrong, it works perfectly.
> Whereas indeed the code proposed by Will didn't work very well.
> I will take Russell's suggestion.

Fine by me. Somehow I thought this was jumping into C but it's actually way
earlier than that.

Sorry for the confusion,

Will