[PATCH V5 5/5] arm: mvebu: Added SMP support for Armada XP

Russell King - ARM Linux linux at arm.linux.org.uk
Wed Nov 21 23:26:10 EST 2012


On Wed, Nov 21, 2012 at 12:22:51PM +0000, Will Deacon wrote:
> Sorry, my mistake (I was thinking on my feet) since secondary_startup is
> declared in a C file, right? How about:
> 
> 	ldr	lr, =secondary_startup
> 	b	ll_set_cpu_coherent

Why?  Do we really want LR to be the _virtual_ address?  No we don't,
because secondary_startup expects to be called with the MMU off.

So I go back to my original comment.  What's wrong with:

	bl	ll_set_cpu_coherent
	b	secondary_startup

?


More information about the devicetree-discuss mailing list